-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(pageserver): add delta records tests for gc-compaction #8078
Conversation
Signed-off-by: Alex Chi Z <[email protected]>
Signed-off-by: Alex Chi Z <[email protected]>
2941 tests run: 2824 passed, 0 failed, 117 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
b139c89 at 2024-06-24T15:55:07.173Z :recycle: |
daea4b1
to
b37d988
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test changes LGTM
Were the changes in compaction.rs exposed by the added tests?
I don't fully understand why the split point business is necessary. Happy to follow up on this post-merge though.
Yes, the tests reveal some bugs within the compaction algorithm. When it comes to the k-merge re-implementation of that part, we can do a thorough review. |
Signed-off-by: Alex Chi Z <[email protected]>
…h/legacy-enhanced-gc-delta
…h/legacy-enhanced-gc-delta
Signed-off-by: Alex Chi Z <[email protected]>
Signed-off-by: Alex Chi Z <[email protected]>
Part of #8002 This pull request adds tests for bottom-most gc-compaction with delta records. Also fixed a bug in the compaction process that creates overlapping delta layers by force splitting at the original delta layer boundary. --------- Signed-off-by: Alex Chi Z <[email protected]>
Problem
Part of #8002
This pull request adds tests for bottom-most gc-compaction with delta records. Also fixed a bug in the compaction process that creates overlapping delta layers by force splitting at the original delta layer boundary.
Summary of changes
Checklist before requesting a review
Checklist before merging