Improve parsing of ImageCompressionAlgorithm
#8281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 tasks
skyzh
approved these changes
Jul 5, 2024
3067 tests run: 2952 passed, 0 failed, 115 skipped (full report)Flaky tests (6)Postgres 15
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
934fdc0 at 2024-07-05T20:25:50.916Z :recycle: |
Closed
VladLazar
pushed a commit
that referenced
this pull request
Jul 8, 2024
Improve parsing of the `ImageCompressionAlgorithm` enum to allow level customization like `zstd(1)`, as strum only takes `Default::default()`, i.e. `None` as the level. Part of #5431
VladLazar
pushed a commit
that referenced
this pull request
Jul 8, 2024
Improve parsing of the `ImageCompressionAlgorithm` enum to allow level customization like `zstd(1)`, as strum only takes `Default::default()`, i.e. `None` as the level. Part of #5431
VladLazar
pushed a commit
that referenced
this pull request
Jul 8, 2024
Improve parsing of the `ImageCompressionAlgorithm` enum to allow level customization like `zstd(1)`, as strum only takes `Default::default()`, i.e. `None` as the level. Part of #5431
VladLazar
pushed a commit
that referenced
this pull request
Jul 8, 2024
Improve parsing of the `ImageCompressionAlgorithm` enum to allow level customization like `zstd(1)`, as strum only takes `Default::default()`, i.e. `None` as the level. Part of #5431
VladLazar
pushed a commit
that referenced
this pull request
Jul 8, 2024
Improve parsing of the `ImageCompressionAlgorithm` enum to allow level customization like `zstd(1)`, as strum only takes `Default::default()`, i.e. `None` as the level. Part of #5431
VladLazar
pushed a commit
that referenced
this pull request
Jul 8, 2024
Improve parsing of the `ImageCompressionAlgorithm` enum to allow level customization like `zstd(1)`, as strum only takes `Default::default()`, i.e. `None` as the level. Part of #5431
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve parsing of the
ImageCompressionAlgorithmenum to allow level customization likezstd(1), as strum only takesDefault::default(), i.e.0as the level, which the zstd library interprets as "take default", i.e. level 3.Part of #5431