-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(pageserver): add test_gc_feedback_with_snapshots #8474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyzh
added
the
run-benchmarks
Indicates to the CI that benchmarks should be run for PR marked with this label
label
Jul 23, 2024
3150 tests run: 3029 passed, 0 failed, 121 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
d06d6c3 at 2024-07-30T20:19:15.723Z :recycle: |
skyzh
force-pushed
the
skyzh/test-gc-feedback-snapshot
branch
2 times, most recently
from
July 25, 2024 18:21
50412a2
to
a7afdd1
Compare
33 tasks
Signed-off-by: Alex Chi Z <[email protected]>
Signed-off-by: Alex Chi Z <[email protected]>
Signed-off-by: Alex Chi Z <[email protected]>
skyzh
force-pushed
the
skyzh/test-gc-feedback-snapshot
branch
from
July 29, 2024 16:43
a7afdd1
to
7bcc1f9
Compare
The benchmark is running in the benchmarks(3) job, while the original one is in benchmarks(2), seems that the CI job is very smart at splitting those things... |
problame
reviewed
Jul 30, 2024
Signed-off-by: Alex Chi Z <[email protected]>
Signed-off-by: Alex Chi Z <[email protected]>
problame
approved these changes
Jul 31, 2024
arpad-m
pushed a commit
that referenced
this pull request
Aug 5, 2024
should be working after #8328 gets merged. Part of #8002 adds a new perf benchmark case that ensures garbages can be collected with branches --------- Signed-off-by: Alex Chi Z <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
run-benchmarks
Indicates to the CI that benchmarks should be run for PR marked with this label
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
should be working after #8328 gets merged. Part of #8002
Summary of changes
adds a new perf benchmark case that ensures garbages can be collected with branches
Checklist before requesting a review
Checklist before merging