Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist archival information #8479

Merged
merged 17 commits into from
Jul 27, 2024
Merged

Persist archival information #8479

merged 17 commits into from
Jul 27, 2024

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented Jul 23, 2024 •
edited
Loading

Stores whether a timeline is archived or not in index_part.json. We only return success if the upload has actually worked successfully.

Also introduces a new index_part.json version number.

Fixes #8459

Part of #8088

@arpad-m arpad-m requested a review from skyzh July 23, 2024 23:01
@arpad-m arpad-m requested a review from a team as a code owner July 23, 2024 23:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

3190 tests run: 3069 passed, 0 failed, 121 skipped (full report)

Flaky tests (1)

Postgres 15

  • test_duplicate_creation: debug

Code coverage* (full report)

  • functions: 32.8% (7008 of 21360 functions)
  • lines: 50.0% (55819 of 111568 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
0668475 at 2024-07-27T02:39:57.153Z :recycle:

@arpad-m arpad-m mentioned this pull request Jul 24, 2024
Open
skyzh
skyzh approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pageserver/src/tenant.rs Outdated Show resolved Hide resolved
storage_scrubber/src/checks.rs Outdated Show resolved Hide resolved
@arpad-m arpad-m enabled auto-merge (squash) July 25, 2024 01:44
@arpad-m arpad-m requested a review from koivunej July 26, 2024 05:28
koivunej
koivunej reviewed Jul 26, 2024
View reviewed changes
Copy link
Member

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flushing accidential comment, let's have a call

pageserver/src/tenant.rs Show resolved Hide resolved
koivunej
koivunej reviewed Jul 26, 2024
View reviewed changes
pageserver/src/tenant.rs Outdated Show resolved Hide resolved
arpad-m added 2 commits July 26, 2024 12:23
@arpad-m
Make it pub(crate)
d3678f5
@arpad-m
Move logic into remote_timeline_client
4e47574 
There we have more ability over the queue and don't need to use
is_archived (which is less precise).
@arpad-m arpad-m force-pushed the arpad/tl-archive-4 branch from 86c7e66 to 4e47574 Compare July 26, 2024 10:47
koivunej
koivunej reviewed Jul 26, 2024
View reviewed changes
pageserver/src/tenant.rs Outdated Show resolved Hide resolved
@arpad-m arpad-m merged commit b5e95f6 into main Jul 27, 2024
65 checks passed
@arpad-m arpad-m deleted the arpad/tl-archive-4 branch July 27, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koivunej koivunej koivunej approved these changes

@skyzh skyzh skyzh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

timeline archival: persistence
3 participants
@arpad-m @koivunej @skyzh