pageserver: remove legacy read path #8601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2108 tests run: 2039 passed, 0 failed, 69 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
87e3c1e at 2024-08-05T11:59:19.024Z :recycle: |
The vectored read path does not support this at the moment
VladLazar
force-pushed
the
vlad/remove-legacy-read-path
branch
from
2a1564b to
2891818
Compare
skyzh
approved these changes
Aug 5, 2024
arpad-m
approved these changes
Aug 5, 2024
As a note, I think it would be useful to move and keep the the tests in Also, it might be useful to eventually remove the |
Yes, I will do the configs in a follow-up |
5 tasks
jcsp
pushed a commit
that referenced
this pull request
Aug 12, 2024
## Problem We have been maintaining two read paths (legacy and vectored) for a while now. The legacy read-path was only used for cross validation in some tests. ## Summary of changes * Tweak all tests that were using the legacy read path to use the vectored read path instead * Remove the read path dispatching based on the pageserver configs * Remove the legacy read path code We will be able to remove the single blob io code in `pageserver/src/tenant/blob_io.rs` when #7386 is complete. Closes #8005
VladLazar
added a commit
that referenced
this pull request
Aug 12, 2024
It has been virtuall unused since #8601
5 tasks
VladLazar
added a commit
that referenced
this pull request
Aug 13, 2024
## Problem Pageserver exposes some vectored get related configs which are not in use. ## Summary of changes Remove the following pageserver configs: get_impl, get_vectored_impl, and `validate_get_vectored`. They are not used in the pageserver since #8601. Manual overrides have been removed from the aws repo in neondatabase/infra#1664.
problame
added a commit
that referenced
this pull request
Dec 13, 2024
…global` As of commit "pageserver: remove legacy read path" (#8601) we always use vectored get, which has a separate metric.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We have been maintaining two read paths (legacy and vectored) for a while now. The legacy read-path
was only used for cross validation in some tests.
Summary of changes
We will be able to remove the single blob io code in
pageserver/src/tenant/blob_io.rswhen#7386 is complete.
Closes #8005
Checklist before requesting a review
Checklist before merging