-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pageserver): support partial gc-compaction for lowest retain lsn #9134
Merged
+410
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5292 tests run: 5070 passed, 0 failed, 222 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
4aa8ec6 at 2024-10-29T17:30:44.815Z :recycle: |
skyzh
force-pushed
the
skyzh/partial-compaction
branch
from
September 24, 2024 22:26
12ae882
to
21cbd41
Compare
skyzh
force-pushed
the
skyzh/partial-compaction
branch
2 times, most recently
from
October 20, 2024 18:55
ba7fa81
to
959a425
Compare
Signed-off-by: Alex Chi Z <[email protected]>
skyzh
force-pushed
the
skyzh/partial-compaction
branch
from
October 20, 2024 18:57
959a425
to
6e89a2e
Compare
skyzh
changed the title
feat(pageserver): support partial gc-compaction
feat(pageserver): support partial gc-compaction for lowest retain lsn
Oct 21, 2024
28 tasks
problame
reviewed
Oct 23, 2024
problame
reviewed
Oct 23, 2024
Co-authored-by: Christian Schwarz <[email protected]>
Co-authored-by: Christian Schwarz <[email protected]>
…h/partial-compaction
Signed-off-by: Alex Chi Z <[email protected]>
Signed-off-by: Alex Chi Z <[email protected]>
problame
approved these changes
Oct 29, 2024
…h/partial-compaction
Signed-off-by: Alex Chi Z <[email protected]>
Signed-off-by: Alex Chi Z <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
part of #8921, #9114
Summary of changes
We start the partial compaction implementation with the image layer partial generation. The partial compaction API now takes a key range. We will only generate images for that key range for now, and remove layers fully included in the key range after compaction.
Checklist before requesting a review
Checklist before merging