Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: remove AdjacentVectoredReadBuilder and bump minmimum io_buffer_alignment to 512 #9175

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

yliang412
Copy link
Contributor

@yliang412 yliang412 commented Sep 26, 2024

Part of #8130

Problem

After deploying https://github.com/neondatabase/infra/pull/1927, we shipped io_buffer_alignment=512 to all prod region. The AdjacentVectoredReadBuilder code path is no longer taken and we are running pageserver unit tests 6 times in the CI. Removing it would reduce the test duration by 30-60s.

Summary of changes

  • Remove AdjacentVectoredReadBuilder code.
  • Bump the minimum io_buffer_alignment requirement to at least 512 bytes.
  • Use default io_buffer_alignment for Rust unit tests.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

github-actions bot commented Sep 26, 2024

5013 tests run: 4855 passed, 0 failed, 158 skipped (full report)


Flaky tests (7)

Postgres 17

Postgres 16

Postgres 15

  • test_ondemand_wal_download_in_replication_slot_funcs: release-arm64

Code coverage* (full report)

  • functions: 32.0% (7487 of 23412 functions)
  • lines: 50.0% (60486 of 120990 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
677f9a4 at 2024-09-27T15:37:13.458Z :recycle:

@yliang412 yliang412 marked this pull request as ready for review September 27, 2024 13:09
@yliang412 yliang412 requested a review from a team as a code owner September 27, 2024 13:09
@yliang412 yliang412 requested a review from arpad-m September 27, 2024 13:09
@yliang412 yliang412 enabled auto-merge (squash) September 27, 2024 14:40
@yliang412 yliang412 self-assigned this Sep 27, 2024
@yliang412 yliang412 merged commit d56c4e7 into main Sep 27, 2024
82 checks passed
@yliang412 yliang412 deleted the yuchen/remove-adjacent-vectored-read-builder branch September 27, 2024 15:41
bayandin pushed a commit that referenced this pull request Sep 29, 2024
…buffer_alignment to 512 (#9175)

Part of #8130

## Problem

After deploying neondatabase/infra#1927, we
shipped `io_buffer_alignment=512` to all prod region. The
`AdjacentVectoredReadBuilder` code path is no longer taken and we are
running pageserver unit tests 6 times in the CI. Removing it would
reduce the test duration by 30-60s.

## Summary of changes

- Remove `AdjacentVectoredReadBuilder` code.
- Bump the minimum `io_buffer_alignment` requirement to at least 512
bytes.
- Use default `io_buffer_alignment` for Rust unit tests.

Signed-off-by: Yuchen Liang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants