-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pageserver: tweak oversized key read path warning #9221
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladLazar
changed the title
Vlad/tweak oversized key warn
pageserver: tweak oversized key read path warning
Oct 1, 2024
5084 tests run: 4897 passed, 1 failed, 186 skipped (full report)Failures on Postgres 17
Flaky tests (2)Postgres 16
Postgres 15
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
1464ba1 at 2024-10-03T14:50:40.412Z :recycle: |
hlinnaka
approved these changes
Oct 1, 2024
CLOG SLRU delta records have a theoretical limit of 128KiB, but due to storage overhead they can be a bit larger. Bump the limit by 2 KiB to avoid warning on reading them.
VladLazar
force-pushed
the
vlad/tweak-oversized-key-warn
branch
from
October 2, 2024 20:39
f1f245a
to
b6087fd
Compare
koivunej
reviewed
Oct 3, 2024
koivunej
reviewed
Oct 3, 2024
koivunej
reviewed
Oct 3, 2024
koivunej
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smaller notes... I guess we are always bound, but prefer the additional comments and display impl.
arpad-m
reviewed
Oct 3, 2024
arpad-m
approved these changes
Oct 3, 2024
erikgrinaker
pushed a commit
that referenced
this pull request
Oct 4, 2024
## Problem `Oversized vectored read [...]` logs are spewing in prod because we have a few keys that are unexpectedly large: * reldir/relblock - these are unbounded, so it's known technical debt * slru block - they can be a bit bigger than 128KiB due to storage format overhead ## Summary of changes * Bump threshold to 130KiB * Don't warn on oversized reldir and dbdir keys Closes #8967
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Oversized vectored read [...]
logs are spewing in prod because we have a few keys thatare unexpectedly large:
Summary of changes
Closes #8967
Checklist before requesting a review
Checklist before merging