Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: tweak oversized key read path warning #9221

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

VladLazar
Copy link
Contributor

Problem

Oversized vectored read [...] logs are spewing in prod because we have a few keys that
are unexpectedly large:

  • reldir/relblock - these are unbounded, so it's known technical debt
  • slru block - they can be a bit bigger than 128KiB due to storage format overhead

Summary of changes

  • Bump threshold to 130KiB
  • Don't warn on oversized reldir and dbdir keys

Closes #8967

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@VladLazar VladLazar requested a review from a team as a code owner October 1, 2024 13:23
@VladLazar VladLazar requested a review from yliang412 October 1, 2024 13:23
@VladLazar VladLazar changed the title Vlad/tweak oversized key warn pageserver: tweak oversized key read path warning Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

5084 tests run: 4897 passed, 1 failed, 186 skipped (full report)


Failures on Postgres 17

  • test_storage_controller_heartbeats[failure3]: debug-x86-64
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_storage_controller_heartbeats[debug-pg17-failure3]"
Flaky tests (2)

Postgres 16

  • test_ondemand_wal_download_in_replication_slot_funcs: release-x86-64

Postgres 15

Code coverage* (full report)

  • functions: 31.4% (7491 of 23884 functions)
  • lines: 49.5% (60135 of 121370 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
1464ba1 at 2024-10-03T14:50:40.412Z :recycle:

libs/pageserver_api/src/config.rs Show resolved Hide resolved
@VladLazar VladLazar enabled auto-merge (squash) October 2, 2024 13:11
CLOG SLRU delta records have a theoretical limit of 128KiB, but due
to storage overhead they can be a bit larger. Bump the limit by 2
KiB to avoid warning on reading them.
@VladLazar VladLazar force-pushed the vlad/tweak-oversized-key-warn branch from f1f245a to b6087fd Compare October 2, 2024 20:39
Copy link
Member

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smaller notes... I guess we are always bound, but prefer the additional comments and display impl.

@VladLazar VladLazar merged commit 552fa2b into main Oct 3, 2024
80 checks passed
@VladLazar VladLazar deleted the vlad/tweak-oversized-key-warn branch October 3, 2024 15:40
erikgrinaker pushed a commit that referenced this pull request Oct 4, 2024
## Problem

`Oversized vectored read [...]` logs are spewing in prod because we have
a few keys that
are unexpectedly large:
* reldir/relblock - these are unbounded, so it's known technical debt
* slru block - they can be a bit bigger than 128KiB due to storage
format overhead

## Summary of changes

* Bump threshold to 130KiB
* Don't warn on oversized reldir and dbdir keys 

Closes #8967
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

noisy Oversized vectored read (131100 > 131072) for keys in prod logs
4 participants