Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pageserver): reduce aux compaction threshold #9647

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Nov 5, 2024

Problem

ref #9441
The metrics from LR publisher testing project: ~300KB aux key deltas per 256MB files. Therefore, I think we can do compaction more aggressively as these deltas are small and compaction can reduce layer download latency. We also have a read path perf fix #9631 but I'd still combine the read path fix with the reduce of the compaction threshold.

Summary of changes

  • reduce metadata compaction threshold
  • use num of L1 delta layers as an indicator for metadata compaction
  • dump more logs

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@skyzh skyzh requested a review from a team as a code owner November 5, 2024 16:55
@skyzh skyzh requested review from arssher and VladLazar November 5, 2024 16:55
Copy link

github-actions bot commented Nov 5, 2024

5328 tests run: 5106 passed, 0 failed, 222 skipped (full report)


Code coverage* (full report)

  • functions: 31.6% (7799 of 24712 functions)
  • lines: 49.0% (61148 of 124775 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
b0ef4e7 at 2024-11-05T21:56:44.504Z :recycle:

@skyzh skyzh force-pushed the skyzh/reduce-compaction-threshold-aux branch from 593f19d to b0ef4e7 Compare November 5, 2024 21:02
@skyzh skyzh requested review from arpad-m and removed request for arssher November 5, 2024 21:03
@skyzh skyzh merged commit a8d9939 into main Nov 7, 2024
77 checks passed
@skyzh skyzh deleted the skyzh/reduce-compaction-threshold-aux branch November 7, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants