Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: Read cplane JWT with clap arg #9654

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

cloneable
Copy link
Contributor

@cloneable cloneable commented Nov 6, 2024

This is mostly a no-op. It just moves where we read the env var from somewhere deep in the code to init code. We do introduce a new flag, which might come in handy.

@cloneable cloneable requested a review from a team as a code owner November 6, 2024 09:23
@cloneable cloneable requested a review from awarus November 6, 2024 09:23
Copy link

github-actions bot commented Nov 6, 2024

5328 tests run: 5106 passed, 0 failed, 222 skipped (full report)


Flaky tests (1)

Postgres 17

Code coverage* (full report)

  • functions: 31.6% (7798 of 24711 functions)
  • lines: 49.0% (61163 of 124797 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
c6b54a7 at 2024-11-06T10:20:59.636Z :recycle:

@cloneable cloneable enabled auto-merge (squash) November 6, 2024 10:22
@cloneable cloneable merged commit 5d8284c into main Nov 6, 2024
82 checks passed
@cloneable cloneable deleted the cloneable/proxy/use-clap-to-read-cplane-token branch November 6, 2024 10:27
@awarus awarus mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants