test_runner: skip more tests using decorator instead of pytest.skip #9704
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Running
pytest.skip(...)
in a test body instead of marking the test with@pytest.mark.skipif(...)
makes all fixtures to be initialised, which is not necessary if the test is going to be skipped anyway.Also, some tests are unnecessarily skipped (e.g.
test_layer_bloating
on Postgres 17, ortest_idle_reconnections
at all) or run (e.g.test_parse_project_git_version_output_positive
more than on once configuration) according to comments.Summary of changes
skip_on_postgres
/xfail_on_postgres
/run_only_on_default_postgres
decorators tofixture.utils
skip_in_debug_build
andskip_on_ci
decoratorspytest.skip(...)
calls with decorators where possibleChecklist before requesting a review
Checklist before merging