Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(pageserver): add gc-compaction tests with delta will_init #9724

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Nov 11, 2024

Problem

I had an impression that gc-compaction didn't test the case where the first record of the key history is will_init because of there are some code path that will panic in this case. Luckily it got fixed in #9026 so we can now implement such tests.

Part of #9114

Summary of changes

  • Randomly changed some images into will_init neon wal record
  • Split test_simple_bottom_most_compaction_deltas into two test cases, one of them has the bottom layer as delta layer with will_init flags, while the other is the original one with image layers.

@skyzh skyzh requested a review from arpad-m November 11, 2024 22:00
@skyzh skyzh requested a review from a team as a code owner November 11, 2024 22:00
@skyzh skyzh mentioned this pull request Nov 11, 2024
28 tasks
Copy link

github-actions bot commented Nov 11, 2024

5382 tests run: 5162 passed, 0 failed, 220 skipped (full report)


Flaky tests (1)

Postgres 15

Code coverage* (full report)

  • functions: 31.8% (7886 of 24832 functions)
  • lines: 49.5% (62444 of 126261 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
4a5d89e at 2024-11-11T23:42:03.066Z :recycle:

Signed-off-by: Alex Chi Z <[email protected]>
Signed-off-by: Alex Chi Z <[email protected]>
@skyzh skyzh merged commit cef1658 into main Nov 12, 2024
80 checks passed
@skyzh skyzh deleted the skyzh/gc-compaction-will-init branch November 12, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants