Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move logic for ingest benchmark from GitHub workflow into python testcase #9762

Merged
merged 33 commits into from
Nov 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
5d3f9ec
first version of pgcopydb test as pytest
Bodobolero Nov 13, 2024
eeb6fb3
make mypy linter happy
Bodobolero Nov 13, 2024
6535247
add endpoint to perf test results db
Bodobolero Nov 14, 2024
1a633dd
adjust workflows to use / ignore new testcase
Bodobolero Nov 14, 2024
1ec2963
first version of pgcopydb test as pytest
Bodobolero Nov 13, 2024
2d9411d
make mypy linter happy
Bodobolero Nov 13, 2024
9f7749e
add endpoint to perf test results db
Bodobolero Nov 14, 2024
0632db9
adjust workflows to use / ignore new testcase
Bodobolero Nov 14, 2024
087cae1
resolve workflow name conflict
Bodobolero Nov 14, 2024
32e0b2d
specify remote cluster
Bodobolero Nov 14, 2024
fa151ee
Merge branch 'bodobolero/ingest_bench_python' of https://github.com/n…
Bodobolero Nov 14, 2024
87eb5e3
try to get pgcopydb logs in workflow log
Bodobolero Nov 14, 2024
248b792
capture didn't work
Bodobolero Nov 14, 2024
c645d2c
try to run pytest myself
Bodobolero Nov 14, 2024
5d53ff7
debug stdout from pytest
Bodobolero Nov 14, 2024
5f459f3
flush stdout
Bodobolero Nov 14, 2024
6993015
test with flush
Bodobolero Nov 14, 2024
09bd7df
version to be tested and submitted for review
Bodobolero Nov 14, 2024
82f25a1
Merge branch 'main' into bodobolero/ingest_bench_python
Bodobolero Nov 14, 2024
f981d99
update submodule references
Bodobolero Nov 14, 2024
0ec9a05
test to renew S3 token for allure upload
Bodobolero Nov 15, 2024
022154a
vars context is not passed to actions, thus we need to pass it explic…
Bodobolero Nov 15, 2024
912c400
syntax error
Bodobolero Nov 15, 2024
1dcaca2
reuse humantime_to_ms
Bodobolero Nov 15, 2024
c3d53d7
reduce token lifetime for report upload
Bodobolero Nov 15, 2024
327067c
log_file_path fixture session scoped
Bodobolero Nov 15, 2024
6fb8d24
pass env to pgcopydb instead of global env, filter file as fixture
Bodobolero Nov 15, 2024
2c5af8c
use test_output_dir as workdir for pgcopydb to upload summary.json as…
Bodobolero Nov 15, 2024
fd5ddda
use NeonBenchmarker (zenbench) for metric reporting
Bodobolero Nov 15, 2024
ad36ebc
typo in invocation of action run_python_test-sest
Bodobolero Nov 15, 2024
3053cdd
review comments
Bodobolero Nov 18, 2024
1221eff
fix run-python-test-set passing arn for AWS token
Bodobolero Nov 18, 2024
8dab650
avoid double pg version in platform string
Bodobolero Nov 19, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/actions/run-python-test-set/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@ inputs:
description: 'benchmark durations JSON'
required: false
default: '{}'
aws_oicd_role_arn:
description: 'the OIDC role arn to (re-)acquire for allure report upload - if not set call must acquire OIDC role'
required: false
default: ''

runs:
using: "composite"
Expand Down Expand Up @@ -222,6 +226,13 @@ runs:
# (for example if we didn't run the test for non build-and-test workflow)
skip-if-does-not-exist: true

- name: (Re-)configure AWS credentials # necessary to upload reports to S3 after a long-running test
if: ${{ !cancelled() && (inputs.aws_oicd_role_arn != '') }}
uses: aws-actions/configure-aws-credentials@v4
with:
aws-region: eu-central-1
role-to-assume: ${{ inputs.aws_oicd_role_arn }}
role-duration-seconds: 3600 # 1 hour should be more than enough to upload report
- name: Upload test results
if: ${{ !cancelled() }}
uses: ./.github/actions/allure-report-store
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/benchmarking.yml
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ jobs:
--ignore test_runner/performance/test_perf_pgvector_queries.py
--ignore test_runner/performance/test_logical_replication.py
--ignore test_runner/performance/test_physical_replication.py
--ignore test_runner/performance/test_perf_ingest_using_pgcopydb.py
env:
BENCHMARK_CONNSTR: ${{ steps.create-neon-project.outputs.dsn }}
VIP_VAP_ACCESS_TOKEN: "${{ secrets.VIP_VAP_ACCESS_TOKEN }}"
Expand Down
Loading
Loading