Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add start_timeout to the neon_fixtures.py::NeonEnvBuilder::start() #9924

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+8 −1
Open

Add start_timeout to the neon_fixtures.py::NeonEnvBuilder::start() #9924

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e0d827
Pass start_timeout to the neon_fixtrures.py::NeonEnvBuilder::start() …
fedordikarev Nov 28, 2024
4666877
set timeout to 30s only debug builds
fedordikarev Dec 5, 2024
94f5757
set different timeouts for debug and release
fedordikarev Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion test_runner/fixtures/neon_fixtures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,7 @@ def init_start(
default_remote_storage_if_missing: bool = True,
initial_tenant_shard_count: int | None = None,
initial_tenant_shard_stripe_size: int | None = None,
timeout_in_seconds: int | None = None,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bayandin I could make it here default 30s:

wdyt?

Suggested change
timeout_in_seconds: int | None = None,
timeout_in_seconds: int | None = 30,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another observation is that all of those 60 failures happened for debug builds, so we should set a larger timeout for that build_type.
I'd like to get John's opinion on that first

) -> NeonEnv:
"""
Default way to create and start NeonEnv. Also creates the initial_tenant with root initial_timeline.
Expand All @@ -478,7 +479,13 @@ def init_start(
Configuring pageserver with remote storage is now the default. There will be a warning if pageserver is created without one.
"""
env = self.init_configs(default_remote_storage_if_missing=default_remote_storage_if_missing)
env.start()
if timeout_in_seconds is None:
if os.getenv("BUILD_TYPE") == "release":
timeout_in_seconds = 15
elif os.getenv("BUILD_TYPE") == "debug":
timeout_in_seconds = 30

env.start(timeout_in_seconds=timeout_in_seconds)

# Prepare the default branch to start the postgres on later.
# Pageserver itself does not create tenants and timelines, until started first and asked via HTTP API.
Expand Down
Loading