chore: update rust-postgres fork #9931
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7029 tests run: 6720 passed, 1 failed, 308 skipped (full report)Failures on Postgres 17
Flaky tests (7)Postgres 17
Postgres 15
Postgres 14
Test coverage report is not availableThe comment gets automatically updated with the latest test results
18370b1 at 2024-12-04T10:37:49.952Z :recycle: |
conradludgate
force-pushed
the
conrad/switch-to-simpler-rust-postgres-fork
branch
from
d036dd8 to
ebaeaf7
Compare
Base automatically changed from
conrad/vendor-and-reduce-rust-postgres-for-proxy
to
main
November 29, 2024 11:08
conradludgate
force-pushed
the
conrad/switch-to-simpler-rust-postgres-fork
branch
from
d3e1ebe to
4f8b62a
Compare
conradludgate
requested review from
erikgrinaker,
NanoBjorn,
nikitakalyanov and
ololobus
ololobus
approved these changes
Nov 29, 2024
arpad-m
approved these changes
Dec 3, 2024
|
Seems to be consistent e2e test failures. Will look into these. |
conradludgate
force-pushed
the
conrad/switch-to-simpler-rust-postgres-fork
branch
from
4f8b62a to
18370b1
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
Like #9931 but without rebasing upstream just yet, to try and minimise the differences. Removes all proxy-specific commits from the rust-postgres fork, now that proxy no longer depends on them. Merging upstream changes to come later.
awarus
pushed a commit
that referenced
this pull request
Dec 5, 2024
Like #9931 but without rebasing upstream just yet, to try and minimise the differences. Removes all proxy-specific commits from the rust-postgres fork, now that proxy no longer depends on them. Merging upstream changes to come later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to rebase our rust-postgres fork with upstream changes, with many commits removed that were deemed proxy-only. https://github.com/neondatabase/rust-postgres/tree/neon-rebase1
Notable change from upstream tokio-postgres is that
simple_queryfirst returns aRowDecription, then secondarily returns aRow. A lot of neon code was assuming the first item would always be the first row.