Merge the consumption metric pushes #9939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloneable
force-pushed
the
cloneable/proxy-merge-metric-push
branch
2 times, most recently
from
5e8af67 to
8a0b87e
Compare
6952 tests run: 6644 passed, 0 failed, 308 skipped (full report)Flaky tests (3)Postgres 17
Postgres 16
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
3887c91 at 2024-11-29T23:21:36.519Z :recycle: |
conradludgate
approved these changes
Nov 29, 2024
cloneable
force-pushed
the
cloneable/proxy-merge-metric-push
branch
from
873a293 to
3887c91
Compare
awarus
pushed a commit
that referenced
this pull request
Dec 5, 2024
#8564 ## Problem The main and backup consumption metric pushes are completely independent, resulting in different event time windows and different idempotency keys. ## Summary of changes * Merge the push tasks, but keep chunks the same size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8564
Problem
The main and backup consumption metric pushes are completely independent,
resulting in different event time windows and different idempotency keys.
Summary of changes