Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_runner: add visibility map test #9940

Merged
merged 5 commits into from
Dec 10, 2024
Merged

test_runner: add visibility map test #9940

merged 5 commits into from
Dec 10, 2024

Conversation

erikgrinaker
Copy link
Contributor

Verifies that visibility map pages are correctly maintained across shards.

Touches #9914.

@erikgrinaker erikgrinaker requested review from a team and arssher and removed request for a team November 29, 2024 14:16
Copy link

github-actions bot commented Nov 29, 2024

7062 tests run: 6747 passed, 0 failed, 315 skipped (full report)


Flaky tests (2)

Postgres 17

Postgres 14

Code coverage* (full report)

  • functions: 31.4% (8329 of 26527 functions)
  • lines: 47.7% (65604 of 137527 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
d711c80 at 2024-12-10T12:09:42.301Z :recycle:

@erikgrinaker
Copy link
Contributor Author

@arssher Mind having a quick look at this?

Copy link
Contributor

@arssher arssher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do IIUC that the test worked before and after #9895 ?
i.e. it doesn't reveal any real problem?

Also note existence of test_vm_bits.py, I think the test should go there.

@erikgrinaker erikgrinaker added this pull request to the merge queue Dec 10, 2024
@arssher arssher removed this pull request from the merge queue due to a manual request Dec 10, 2024
@arssher
Copy link
Contributor

arssher commented Dec 10, 2024

Mind having a quick look at this?

missed it earlier, sorry

@erikgrinaker
Copy link
Contributor Author

Do IIUC that the test worked before and after #9895 ?

That's right, #9895 was not a correctness problem.

Also note existence of test_vm_bits.py, I think the test should go there.

Good call, done.

@erikgrinaker erikgrinaker added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit ad472bd Dec 10, 2024
80 checks passed
@erikgrinaker erikgrinaker deleted the erik/vm-test branch December 10, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants