Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storcon: include preferred AZ in compute notifications #9953

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Conversation

jcsp
Copy link
Collaborator

@jcsp jcsp commented Nov 29, 2024

Problem

It is unreliable for the control plane to infer the AZ for computes from where the tenant is currently attached, because if a tenant happens to be in a degraded state or a release is ongoing while a compute starts, then the tenant's attached AZ can be a different one to where it will run long-term, and the control plane doesn't check back later to restart the compute.

This can land in parallel with #9947

Summary of changes

  • Thread through the preferred AZ into the compute hook code via the reconciler
  • Include the preferred AZ in the body of compute hook notifications

@jcsp jcsp added t/feature Issue type: feature, for new features or requests c/storage/controller Component: Storage Controller labels Nov 29, 2024
Copy link

github-actions bot commented Nov 29, 2024

7136 tests run: 6839 passed, 0 failed, 297 skipped (full report)


Flaky tests (3)

Postgres 17

Code coverage* (full report)

  • functions: 31.4% (8404 of 26785 functions)
  • lines: 48.1% (66657 of 138684 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
670cdef at 2024-12-16T17:20:02.760Z :recycle:

@jcsp jcsp marked this pull request as ready for review December 7, 2024 16:11
@jcsp jcsp requested a review from a team as a code owner December 7, 2024 16:11
@jcsp jcsp requested a review from arssher December 7, 2024 16:11
@jcsp jcsp requested a review from VladLazar December 11, 2024 13:31
storage_controller/src/compute_hook.rs Outdated Show resolved Hide resolved
storage_controller/src/compute_hook.rs Outdated Show resolved Hide resolved
@jcsp jcsp enabled auto-merge December 16, 2024 11:12
@jcsp jcsp added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit fd23022 Dec 17, 2024
83 checks passed
@jcsp jcsp deleted the jcsp/az-notify branch December 17, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/storage/controller Component: Storage Controller t/feature Issue type: feature, for new features or requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants