Online checkpoint replication state #9976
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7084 tests run: 6787 passed, 0 failed, 297 skipped (full report)Flaky tests (5)Postgres 17
Postgres 15
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
4f1cbd0 at 2024-12-16T07:37:34.191Z :recycle: |
knizhnik
force-pushed
the
online_repl_checkpoint
branch
from
06493e8 to
f708a17
Compare
knizhnik
force-pushed
the
online_repl_checkpoint
branch
from
f708a17 to
4f1cbd0
Compare
hlinnaka
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Approved per discussion at neondatabase/postgres#546 (review). Let's open a separate PR for the cleanups discussed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See https://neondb.slack.com/archives/C04DGM6SMTM/p1733180965970089
Replication state is checkpointed only by shutdown checkpoint.
It means that replication snapshots are not removed till compute shutdown.
Summary of changes
Checkpoint replication state during online checkpoint
Related Postgres PR:
neondatabase/postgres#546