-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the pg_regress tests on staging for PG17 #9978
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/use-branches-in-regression-tests
a-masterov
changed the title
Amasterov/regress staging 17
Enable the pg_regress tests on staging for PG17
Dec 3, 2024
7051 tests run: 6726 passed, 0 failed, 325 skipped (full report)Flaky tests (6)Postgres 17
Postgres 15
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
427a573 at 2024-12-09T18:17:54.185Z :recycle: |
…into amasterov/regress-staging-17
bayandin
reviewed
Dec 6, 2024
bayandin
reviewed
Dec 9, 2024
knizhnik
approved these changes
Dec 9, 2024
bayandin
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Need to delete one more extra file, and we're good to merge it! Well done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, we run the
pg_regress
tests only for PG16However, PG17 is a part of Neon and should be tested as well
Summary of changes
Modified the workflow and added a patch for PG17 enabling the
pg_regress
tests.The problem with leftovers was solved by using branches.