Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proxy): add option to forward startup params #9979

Merged
merged 12 commits into from
Dec 4, 2024

Conversation

conradludgate
Copy link
Contributor

@conradludgate conradludgate commented Dec 3, 2024

(stacked on #9990 and #9995)

Partially fixes #1287 with a custom option field to enable the fixed behaviour. This allows us to gradually roll out the fix without silently changing the observed behaviour for our customers.

related to https://github.com/neondatabase/cloud/issues/15284

Copy link

github-actions bot commented Dec 3, 2024

7040 tests run: 6732 passed, 0 failed, 308 skipped (full report)


Flaky tests (6)

Postgres 17

Postgres 16

Postgres 15

Postgres 14

Code coverage* (full report)

  • functions: 30.8% (8263 of 26822 functions)
  • lines: 47.8% (65155 of 136301 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
765be4b at 2024-12-04T12:47:28.720Z :recycle:

@conradludgate conradludgate force-pushed the conrad/proxy-forward-arbitrary-options branch from 04e76e5 to 2f052b3 Compare December 3, 2024 15:56
@conradludgate conradludgate changed the base branch from main to conrad/remove-postgres-config-parser December 3, 2024 15:56
@conradludgate conradludgate force-pushed the conrad/proxy-forward-arbitrary-options branch from 2f052b3 to c103af7 Compare December 3, 2024 16:13
@conradludgate conradludgate changed the base branch from conrad/remove-postgres-config-parser to conrad/enforce-single-host-port December 3, 2024 16:14
@conradludgate conradludgate changed the title feat(proxy): add option to forward startup params [wip] feat(proxy): add option to forward startup params Dec 3, 2024
@conradludgate conradludgate marked this pull request as ready for review December 3, 2024 16:15
@conradludgate conradludgate requested a review from a team as a code owner December 3, 2024 16:15
@conradludgate conradludgate requested review from cloneable and removed request for a team December 3, 2024 16:15
@conradludgate conradludgate force-pushed the conrad/enforce-single-host-port branch from b47e96a to 0da5564 Compare December 3, 2024 18:58
@conradludgate conradludgate force-pushed the conrad/proxy-forward-arbitrary-options branch from c103af7 to 67c46e1 Compare December 3, 2024 19:04
Base automatically changed from conrad/enforce-single-host-port to main December 3, 2024 20:01
@conradludgate conradludgate force-pushed the conrad/proxy-forward-arbitrary-options branch from 67c46e1 to 1fad360 Compare December 4, 2024 08:18
libs/proxy/postgres-protocol2/src/message/frontend.rs Outdated Show resolved Hide resolved
proxy/src/proxy/mod.rs Outdated Show resolved Hide resolved
proxy/src/proxy/mod.rs Outdated Show resolved Hide resolved
proxy/src/proxy/mod.rs Outdated Show resolved Hide resolved
proxy/src/compute.rs Show resolved Hide resolved
@conradludgate conradludgate added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit bd52822 Dec 4, 2024
82 checks passed
@conradludgate conradludgate deleted the conrad/proxy-forward-arbitrary-options branch December 4, 2024 13:01
@awarus awarus mentioned this pull request Dec 5, 2024
awarus pushed a commit that referenced this pull request Dec 5, 2024
(stacked on #9990 and #9995)

Partially fixes #1287 with a custom option field to enable the fixed
behaviour. This allows us to gradually roll out the fix without silently
changing the observed behaviour for our customers.

related to neondatabase/cloud#15284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forward parameters to compute in proxy
2 participants