backend: pack next record LSN into the encoded message #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field only needs to be read after the batch is decoded, so we can move into the body to get more efficient encoding.
erikgrinaker
approved these changes
Nov 25, 2024
github-merge-queue bot
pushed a commit
to neondatabase/neon
that referenced
this pull request
Nov 27, 2024
…#9821) ## Problem #9746 lifted decoding and interpretation of WAL to the safekeeper. This reduced the ingested amount on the pageservers by around 10x for a tenant with 8 shards, but doubled the ingested amount for single sharded tenants. Also, #9746 uses bincode which doesn't support schema evolution. Technically the schema can be evolved, but it's very cumbersome. ## Summary of changes This patch set addresses both problems by adding protobuf support for the interpreted wal records and adding compression support. Compressed protobuf reduced the ingested amount by 100x on the 32 shards `test_sharded_ingest` case (compared to non-interpreted proto). For the 1 shard case the reduction is 5x. Sister change to `rust-postgres` is [here](neondatabase/rust-postgres#33). ## Links Related: #9336 Epic: #9329
conradludgate
pushed a commit
that referenced
this pull request
Nov 28, 2024
This field only needs to be read after the batch is decoded, so we can move into the body to get more efficient encoding.
conradludgate
pushed a commit
that referenced
this pull request
Dec 4, 2024
This field only needs to be read after the batch is decoded, so we can move into the body to get more efficient encoding.
conradludgate
pushed a commit
that referenced
this pull request
Dec 4, 2024
This field only needs to be read after the batch is decoded, so we can move into the body to get more efficient encoding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field only needs to be read after the batch is decoded, so we can move into the body to get more efficient encoding.