vendor IoBuf/IoBufMut from tokio-uring
#24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
problame
force-pushed
the
problame/uring-common
branch
from
16d09a9 to
04cb1bd
Compare
For [`open_at` support](#21) we need an `OpenOptions` struct. Sadly we can't re-use the one from `tokio-uring` because it doesn't have a public API for the conversion of OpenOptions into the relevant libc flags. We created [a PR asking for such an API](neondatabase/tokio-uring#1), but, in the meantime, let's unblock ourselves by vendoring the pieces of `tokio-uring` that we need, and cusotmize them as needed. This PR starts that effort by vendoring the `IoBuf`/`IoBufMut` traits. `OpenOptions` will follow in a later PR. The files that reproduce the `tokio-uring` LICENSE text at the top are copied from `tokio-uring.git:d5e90539bd6d1c518e848298564a098c300866bc`. Files without it were written by myself.
problame
force-pushed
the
problame/uring-common
branch
from
04cb1bd to
716ef11
Compare
problame
changed the title
tokio-uringIoBuf/IoBufMut from tokio-uring
arpad-m
approved these changes
Nov 20, 2023
problame
added a commit
that referenced
this pull request
Nov 22, 2023
(Stacked atop #24) * Vendor in `OpenOptions` from `tokio-uring.git:d5e90539bd6d1c518e848298564a098c300866bc` * Remove the `OpenOptions::open()` function which is `tokio-uring`-specific * Remove examples because they mention `tokio_uring` and hence fail `cargo test` * Add the extension trait that allows for conversion of OpenOptions into an `io_uring::squeue::Entry` * Use it throughout the code base. This PR obsoletes #21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the draft PR for
open_atsupport we need anOpenOptionsstruct. Sadly we can't re-use the one fromtokio-uringbecause it doesn't have a public API for the conversion of OpenOptions into the relevant libc flags.We created a PR asking for such an API, but, in the meantime, let's unblock ourselves by vendoring the pieces of
tokio-uringthat we need, and cusotmize them as needed.This PR starts that effort by vendoring the
IoBuf/IoBufMuttraits as well astokio-uring's approach to support slice-like operations.Support for
OpenOptionswill follow as part of the PR that addsopen_atsupport on top of this PR.The files that reproduce the
tokio-uringLICENSE text at the top are copied fromtokio-uring.git:d5e90539bd6d1c518e848298564a098c300866bc.Files without it were written by myself.
To make
cargo testpass, I had to remove the examples in the doc comments.