Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable depending on tokio-epoll-uring crate from macOS builds #32

Merged
merged 4 commits into from
Jan 15, 2024

Conversation

problame
Copy link
Collaborator

@problame problame commented Jan 15, 2024

Used by neondatabase/neon#6355

The alternative would have been to require tokio-epoll-uring users to use uring-common in their Cargo.toml.

Instead, we keep the re-exports of uring-common from tokio-epoll-uring, so that users can think of it as one crate.
As a bonus, the examples look nice.

@problame problame changed the title enable build of uring-common on macOS enable depending on tokio-epoll-uring crate from macOS builds Jan 15, 2024
@problame problame requested a review from koivunej January 15, 2024 14:49
@problame problame merged commit 0dd3a2f into main Jan 15, 2024
3 checks passed
@problame problame deleted the problame/macos-usage branch January 15, 2024 16:05
problame added a commit to neondatabase/neon that referenced this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants