Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fsync / fdatasync operations #40

Merged
merged 1 commit into from
Feb 8, 2024
Merged

add fsync / fdatasync operations #40

merged 1 commit into from
Feb 8, 2024

Conversation

problame
Copy link
Collaborator

@problame problame commented Feb 7, 2024

No description provided.

@problame problame requested review from jcsp and VladLazar February 7, 2024 09:47
@problame problame mentioned this pull request Feb 7, 2024
@problame problame changed the title add fsync / fdatasync operations add fsync / fdatasync operations Feb 7, 2024
@problame problame removed the request for review from jcsp February 7, 2024 16:24
@@ -141,4 +141,34 @@ impl crate::SystemHandle {
res
})
}

pub async fn fsync<F: IoFd + Send>(
Copy link
Member

@koivunej koivunej Feb 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use the std library naming (sync_all) instead. fdatasync is sync_data.

Copy link
Member

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would use std naming at the api, but cannot see anything wrong.

@problame problame merged commit e6b9204 into main Feb 8, 2024
3 checks passed
@problame problame deleted the problame/fsync branch February 8, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants