Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for failing fossology tests #52

Closed
wants to merge 1 commit into from
Closed

Conversation

radoslawc
Copy link
Contributor

@johnbelamaric
Copy link
Member

/approve

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Oct 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Oct 2, 2023
@henderiw
Copy link
Contributor

henderiw commented Oct 4, 2023

/lgtm

@johnbelamaric
Copy link
Member

@radoslawc the UI-based rebase isn't working for me, with some EasyCLA complaint. Can you try rebasing?

@arora-sagar
Copy link
Contributor

arora-sagar commented Oct 25, 2023

@radoslawc @johnbelamaric can we merge this PR? As it fixes the failing license test.

@radoslawc
Copy link
Contributor Author

@arora-sagar @johnbelamaric Sorry for late reply, missed that one in notifications. I rebase it either, it was made from branch on api repo and it's protected so I cannot update it. I'll close this one and open proper one from fork.
/close

@nephio-prow nephio-prow bot closed this Nov 1, 2023
Copy link
Contributor

nephio-prow bot commented Nov 1, 2023

@radoslawc: Closed this PR.

In response to this:

@arora-sagar @johnbelamaric Sorry for late reply, missed that one in notifications. I rebase it either, it was made from branch on api repo and it's protected so I cannot update it. I'll close this one and open proper one from fork.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants