Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workload Identity reconciler integration using SPIFFE #809

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

PrimalPimmy
Copy link

@PrimalPimmy PrimalPimmy commented Sep 17, 2024

This PR initiates the work to implement workload Identity in the nephio ecosystem. More documentation can be found here:
Design Document: https://docs.google.com/document/d/1k8Hcd7tJKPIsyiYZX6hpRECuJ4IIxVnaESghU5bLNVQ/edit?usp=sharing
User Story: https://docs.google.com/document/d/1nkh7tTItwii1bY877PfzjFCBtmRos4IDh5EOJxWXRdg/edit?usp=sharing
Updating-Kubeconfigs

Copy link
Contributor

nephio-prow bot commented Sep 17, 2024

Hi @PrimalPimmy. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liamfallon
Copy link
Member

/ok-to-test

PrimalPimmy and others added 4 commits September 20, 2024 07:42
Signed-off-by: PrimalPimmy <[email protected]>

minor fix

Signed-off-by: PrimalPimmy <[email protected]>

Cluster reconciler

Signed-off-by: PrimalPimmy <[email protected]>

Cluster reconciler

Signed-off-by: PrimalPimmy <[email protected]>

sending bundle to remote cluster

Signed-off-by: PrimalPimmy <[email protected]>

Test

Signed-off-by: PrimalPimmy <[email protected]>

Spire auth inside reconciler

Signed-off-by: PrimalPimmy <[email protected]>

Vault authentication and fetching kubeconfig

Signed-off-by: PrimalPimmy <[email protected]>

Some testing

Signed-off-by: PrimalPimmy <[email protected]>

Mid testing

Signed-off-by: PrimalPimmy <[email protected]>

Mid testing

Signed-off-by: PrimalPimmy <[email protected]>

Mid testing

Signed-off-by: PrimalPimmy <[email protected]>

Mid testing-2

Signed-off-by: PrimalPimmy <[email protected]>

Mid testing-2

Signed-off-by: PrimalPimmy <[email protected]>

Mid testing-2

Signed-off-by: PrimalPimmy <[email protected]>

Mid testing-3

Signed-off-by: PrimalPimmy <[email protected]>

Mid testing-3

Signed-off-by: PrimalPimmy <[email protected]>

Mid testing-3

Signed-off-by: PrimalPimmy <[email protected]>

Refactoring

Signed-off-by: PrimalPimmy <[email protected]>

Kubeconfig test

Signed-off-by: PrimalPimmy <[email protected]>

Removed found

Signed-off-by: PrimalPimmy <[email protected]>

log testing

Signed-off-by: PrimalPimmy <[email protected]>

log testing

Signed-off-by: PrimalPimmy <[email protected]>

log testing

Signed-off-by: PrimalPimmy <[email protected]>

Getting svid

Signed-off-by: PrimalPimmy <[email protected]>

Getting svid-2

Signed-off-by: PrimalPimmy <[email protected]>

Getting svid-2

Signed-off-by: PrimalPimmy <[email protected]>

Getting svid-3

Signed-off-by: PrimalPimmy <[email protected]>

Getting svid-4

Signed-off-by: PrimalPimmy <[email protected]>

Getting svid-5

Signed-off-by: PrimalPimmy <[email protected]>

Getting svid-6

Signed-off-by: PrimalPimmy <[email protected]>

Vault addr and patch configmap

Signed-off-by: PrimalPimmy <[email protected]>

Vault addr and patch configmap

Signed-off-by: PrimalPimmy <[email protected]>

Restricted Kubeconfig

Signed-off-by: PrimalPimmy <[email protected]>

configmap perms

Signed-off-by: PrimalPimmy <[email protected]>

server addr

Signed-off-by: PrimalPimmy <[email protected]>

Struct to yaml

Signed-off-by: PrimalPimmy <[email protected]>

Struct to yaml

Signed-off-by: PrimalPimmy <[email protected]>

Reverting changes

Signed-off-by: PrimalPimmy <[email protected]>

Reverting changes

Signed-off-by: PrimalPimmy <[email protected]>

Reverting changes

Signed-off-by: PrimalPimmy <[email protected]>

Reverting changes

Signed-off-by: PrimalPimmy <[email protected]>

Reverting changes

Signed-off-by: PrimalPimmy <[email protected]>

Reverting changes

Signed-off-by: PrimalPimmy <[email protected]>

Reverting changes

Signed-off-by: PrimalPimmy <[email protected]>

Reverting changes

Signed-off-by: PrimalPimmy <[email protected]>

yaml indent fixing

Signed-off-by: PrimalPimmy <[email protected]>

yaml indent fixing

Signed-off-by: PrimalPimmy <[email protected]>

yaml indent fixing

Signed-off-by: PrimalPimmy <[email protected]>

Some cleanup

Signed-off-by: PrimalPimmy <[email protected]>

Some cleanup

Signed-off-by: PrimalPimmy <[email protected]>

Debugging

Signed-off-by: PrimalPimmy <[email protected]>

Debugging

Signed-off-by: PrimalPimmy <[email protected]>

Debugging

Signed-off-by: PrimalPimmy <[email protected]>

Debugging

Signed-off-by: PrimalPimmy <[email protected]>

vault storage change

Signed-off-by: PrimalPimmy <[email protected]>

Added kubeconfig change

Signed-off-by: PrimalPimmy <[email protected]>

Spire-agent conf, vault testing

Signed-off-by: PrimalPimmy <[email protected]>

Spire-agent conf, vault testing

Signed-off-by: PrimalPimmy <[email protected]>

Spire-agent conf, vault testing

Signed-off-by: PrimalPimmy <[email protected]>

Spire-agent conf, vault testing

Signed-off-by: PrimalPimmy <[email protected]>

module testing

Signed-off-by: PrimalPimmy <[email protected]>

revert module change

Signed-off-by: PrimalPimmy <[email protected]>

Vault JWT role detect

Signed-off-by: PrimalPimmy <[email protected]>

Vault JWT role detect

Signed-off-by: PrimalPimmy <[email protected]>

Vault JWT role detect-2

Signed-off-by: PrimalPimmy <[email protected]>
Signed-off-by: PrimalPimmy <[email protected]>
Signed-off-by: PrimalPimmy <[email protected]>
@liamfallon
Copy link
Member

/assign @tliron @efiacor @kispaljr

@liamfallon
Copy link
Member

@PrimalPimmy I think maybe we should take another look at this in SIG-Auto. Would you be able to schedule it on the agenda for one of the upcoming meetings?

@PrimalPimmy
Copy link
Author

Sure @liamfallon . Where do I post about this to schedule it?

cc: @nyrahul

@liamfallon
Copy link
Member

Please enter an item on the agenda for a forthcoming meeting, the agenda document is here:
https://docs.google.com/document/d/1SW4acc0950QdDNEvmeHArfNsgKPeY_EIwHBqGBky2CY/edit#heading=h.k7dq727kte8c

Copy link
Contributor

nephio-prow bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from efiacor by writing /assign @efiacor in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants