-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge all of porch's go modules into a single go module #107
Conversation
This is still work-in-progress. I will remove the hold label when it is ready for review. |
…-catalog in order to avoid outdated dependencies
…ing the kpt function source code
/retest |
1 similar comment
/retest |
/retest |
/retest |
1 similar comment
/retest |
@efiacor , @liamfallon this is ready for review now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I'm fully in favour of this approach but could this cause other potential issue that I don't have the golang knowledge to foresee?
@@ -16,15 +16,6 @@ IMAGE_TAG ?= latest | |||
IMAGE_REPO ?= docker.io/nephio | |||
IMAGE_NAME ?= porch-controllers | |||
|
|||
# This includes the following targets: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I didn't fully check but we need to ensure that the code-gen stuff is still sound.
I can only state that |
/approve |
Also, after we merge this, we will have to adjust the go.mod files in the Nephio project. (But first, we have to merge this, so that a commit hash is assigned to the new single module) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I downloaded this PR and it built fine for me
Thanks @kispaljr for this, it'll really help
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: efiacor, kispaljr, liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It was removed in nephio-project/porch#107 Signed-off-by: Gergely Csatari <[email protected]>
It was removed in nephio-project/porch#107 Signed-off-by: Gergely Csatari <[email protected]>
It was removed in nephio-project/porch#107 Signed-off-by: Gergely Csatari <[email protected]>
Currently porch consists of three separate go modules:
These modules depend on each other, and that makes it really hard to introduce changes that touches multiple modules.
This PR aims to put all of the above into one singular porch go module to make the lives of developers considerably easier.