Fix rendering big (>4MB) packages with function-runner #142
Conversation
…for better awareness
| // Parameters of ExecEvaluator | ||
| exec internal.ExecutableEvaluatorOptions | ||
| // Parameters of PodEvaluator | ||
| pod internal.PodEvaluatorOptions |
There was a problem hiding this comment.
Pedantic, so your call if you fix it, but o.pod.wrapperServerImage below were a bit confusing whtether this is actual pod info, or something else. Maybe podeval?
There was a problem hiding this comment.
I am fine with renaming it. Would "WrapperServerConatinerImageName" sound better? Should we also rename the WRAPPER_SERVER_IMAGE envvar where the actual name coming from? The later is a breaking change so probably not. Btw., there is a comment next to the field in the PodEvaluatorOptions struct (that IDEs will find and display) that tries to explain the semantics of the field.
|
/approve |
|
/approve |
|
/approve |
|
/lgtm |
|
/lgtm cancel |
|
Sorry @liamfallon for adding the draft flag last-minute. I made a last-minute test, but everything seems fine, so I removed the draft flag again |
Perfect. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Catalin-Stratulat-Ericsson, efiacor, kispaljr, liamfallon, nagygergo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes nephio-project/nephio#823
PR #121 successfully solved the issue of creating/updating/querying big packages via the porch API. However if a big package has a non-empty pipeline, the rendering of those large packages fail with an error message mentioning grpc max message size (see the issue referenced above). This PR fixes that.
(It also contains some minor refactoring that eliminates some unnecessarily long argument lists in function-runner.)