Fix conftest for e2e #111
Merged
Fix conftest for e2e #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't require `NEPTUNE_PROJECT` env to be set, if `NEPTUNE_PROJECT` is set in a test module
kgodlewski
force-pushed
the
kg/improve-e2e-conftest
branch
from
af0918f to
08d6d93
Compare
This gets rid of errors in the `logging` module, which stem from pytest capturing output
PatrykGala
reviewed
Nov 8, 2024
| @@ -21,6 +22,23 @@ | |||
| # around names and values of the metadata. | |||
|
|
|||
|
|
|||
| @fixture(scope="session", autouse=True) | |||
There was a problem hiding this comment.
PatrykGala
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEPTUNE_PROJECTenv to be set, ifNEPTUNE_PROJECTis set in a test moduleloggingerrors (see pytest capture logging error still happening pytest-dev/pytest#5502)