Skip to content

Commit

Permalink
float3 fix (#44)
Browse files Browse the repository at this point in the history
Co-authored-by: Ruilong Li <[email protected]>
  • Loading branch information
liruilong940607 and Ruilong Li authored Oct 13, 2023
1 parent 9150129 commit 1e64d1c
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 7 deletions.
14 changes: 9 additions & 5 deletions .github/workflows/building.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,15 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-20.04, windows-2019]
# support version based on: https://download.pytorch.org/whl/torch/
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11']
torch-version: [1.11.0, 1.12.0, 1.13.0, 2.0.0]
cuda-version: ['cu113', 'cu115', 'cu116', 'cu117', 'cu118']
os: [windows-2019]
python-version: ['3.7']
torch-version: [1.11.0]
cuda-version: ['cu113']
# os: [ubuntu-20.04, windows-2019]
# # support version based on: https://download.pytorch.org/whl/torch/
# python-version: ['3.7', '3.8', '3.9', '3.10', '3.11']
# torch-version: [1.11.0, 1.12.0, 1.13.0, 2.0.0]
# cuda-version: ['cu113', 'cu115', 'cu116', 'cu117', 'cu118']
exclude:
- torch-version: 1.11.0
python-version: '3.11'
Expand Down
3 changes: 1 addition & 2 deletions gsplat/cuda/csrc/forward.cu
Original file line number Diff line number Diff line change
Expand Up @@ -662,8 +662,7 @@ __device__ float3 project_cov3d_ewa(
glm::mat3 cov = T * V * glm::transpose(T);

// add a little blur along axes and save upper triangular elements
return (float3
){float(cov[0][0]) + 0.3f, float(cov[0][1]), float(cov[1][1]) + 0.3f};
return float3(float(cov[0][0]) + 0.3f, float(cov[0][1]), float(cov[1][1]) + 0.3f);
}

// device helper to get 3D covariance from scale and quat parameters
Expand Down

0 comments on commit 1e64d1c

Please sign in to comment.