Skip to content

Commit

Permalink
Merge pull request #18 from vye16/dev_instr
Browse files Browse the repository at this point in the history
dev instructions
  • Loading branch information
liruilong940607 authored Sep 29, 2023
2 parents b51dc23 + 1f83a45 commit 20b6e44
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/core_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@ jobs:
python-version: "3.8.12"
- name: Install dependencies
run: |
pip install isort==5.10.1 black[jupyter]==22.3.0
pip install black[jupyter]==22.3.0
- name: Run Black Format Check
run: black . diff_rast/ tests/ examples/ --check
2 changes: 2 additions & 0 deletions .github/workflows/doc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ name: Docs
on:
push:
branches: [main]
pull_request:
branches: [main]
workflow_dispatch:

permissions:
Expand Down
25 changes: 25 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,31 @@ If you won't touch the underlying CUDA code, you can just install with compiling
pip install -e .[dev]
```

# Development

## Protect Main Branch over Pull Request.
It is recommend to commit the code into the main branch as a PR over a hard push, as the
PR would protect the main branch if the code break tests but a hard push won't.

The curret tests that will be triggered by PR:
- `.github/workflows/core_tests.yml`: Black formating.
- `.github/workflows/doc.yml`: Doc build.

Because we check for black formatting, it is recommend to run black before commit in the code:
```
black . diff_rast/ tests/ examples/ --check
```

## Build the Doc Locally
If you want to contribute to the doc, here is the way to build it locally. The source code of the doc can be found in `docs/source` and the built doc will be in `_build/`. Here are some examples on documentation: [viser](https://github.com/nerfstudio-project/viser/tree/main/docs/source), [nerfstudio](https://github.com/nerfstudio-project/nerfstudio/tree/main/docs), [nerfacc](https://github.com/KAIR-BAIR/nerfacc/tree/master/docs/source).

```
pip install -e .[dev]
pip install -r docs/requirements.txt
sphinx-build docs/source _build
```



# Brief walkthrough

Expand Down

0 comments on commit 20b6e44

Please sign in to comment.