Fix a bug in scaling screen space grads

nerfstudio-project · Aug 22, 2024 · e9b6a07 · e9b6a07
1 parent 8f8e397
commit e9b6a07
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/gsplat/strategy/default.py b/gsplat/strategy/default.py
@@ -210,8 +210,7 @@ def _update_state(
             grads = info["means2d"].absgrad.clone()
         else:
             grads = info["means2d"].grad.clone()
-        grads[..., 0] *= info["width"] / 2.0 * info["n_cameras"]
-        grads[..., 1] *= info["height"] / 2.0 * info["n_cameras"]
+        grads *= max(info["width"], info["height"]) / 2.0 * info["n_cameras"]
 
         # initialize state on the first run
         n_gaussian = len(list(params.values())[0])