Skip to content

Commit

Permalink
nits
Browse files Browse the repository at this point in the history
  • Loading branch information
Ruilong Li committed Jul 12, 2024
1 parent bcc843c commit ec94f3b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion gsplat/rendering.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def rasterization(
Args:
means: The 3D centers of the Gaussians. [N, 3]
quats: The quaternions of the Gaussians. It's not required to be normalized. [N, 4]
quats: The quaternions of the Gaussians (wxyz convension). It's not required to be normalized. [N, 4]
scales: The scales of the Gaussians. [N, 3]
opacities: The opacities of the Gaussians. [N]
colors: The colors of the Gaussians. [(C,) N, D] or [(C,) N, K, 3] for SH coefficients.
Expand Down
2 changes: 1 addition & 1 deletion gsplat/strategy/ops.py
Original file line number Diff line number Diff line change
Expand Up @@ -323,5 +323,5 @@ def op_sigmoid(x, k=100, x0=0.995):
* (op_sigmoid(1 - opacities)).unsqueeze(-1)
* scaler
)
noise = torch.bmm(covars, noise.unsqueeze(-1)).squeeze(-1)
noise = torch.einsum("bij,bj->bi", covars, noise)
params["means"].add_(noise)
2 changes: 1 addition & 1 deletion gsplat/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ def normalized_quat_to_rotmat(quat: Tensor) -> Tensor:
"""Convert normalized quaternion to rotation matrix.
Args:
quat: Normalized quaternion (..., 4)
quat: Normalized quaternion in wxyz convension. (..., 4)
Returns:
Rotation matrix (..., 3, 3)
Expand Down

0 comments on commit ec94f3b

Please sign in to comment.