Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional masks in rasterize_to_pixels() to support Grendel #284

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Add optional masks in rasterize_to_pixels() to support Grendel #284

merged 3 commits into from
Jul 17, 2024

Conversation

alexis-mmm
Copy link
Contributor

@alexis-mmm alexis-mmm commented Jul 14, 2024 •
edited
Loading

Now rasterize_to_pixels() supports an optional argument masks to identify its local workload in a multi-GPU scenario, so it can better work with Grendel. When a tile is marked as false:

  • In the forward pass, all channels of each pixel in that tile are set to zero.
  • In the backward pass, no operations are performed on that tile.

liruilong940607
liruilong940607 reviewed Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@liruilong940607 liruilong940607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Added some minor comments

gsplat/cuda/csrc/rasterize_to_pixels_bwd.cu Outdated Show resolved Hide resolved
gsplat/cuda/csrc/rasterize_to_pixels_fwd.cu Outdated Show resolved Hide resolved
gsplat/cuda/csrc/rasterize_to_pixels_fwd.cu Outdated Show resolved Hide resolved
gsplat/cuda/_wrapper.py Outdated Show resolved Hide resolved
gsplat/cuda/_wrapper.py Outdated Show resolved Hide resolved
Xiwen Min added 2 commits July 17, 2024 12:40
Fix masks for general use
a4ae410 
1. Render background color in masked area.
2. Check: `masks` and `isect_offsets` should have the same shape.
Fix typo
40ee059
liruilong940607
liruilong940607 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@liruilong940607 liruilong940607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! Thanks for contributing!

@liruilong940607 liruilong940607 merged commit e1de4c3 into nerfstudio-project:main Jul 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liruilong940607 liruilong940607 liruilong940607 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexis-mmm @liruilong940607