Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate simple_trainer.py and simple_trainer_mcmc.py #325

Merged
merged 10 commits into from
Aug 10, 2024

Conversation

brentyi
Copy link
Collaborator

@brentyi brentyi commented Aug 10, 2024

Not fully tested yet, but here's a config structure suggestion to make this API possible: python simple_trainer.py {default,mcmc}.

python simple_trainer.py --help:

image

Default densification: python simple_trainer.py default --help

image

MCMC densification: python simple_trainer.py mcmc --help

image

@brentyi
Copy link
Collaborator Author

brentyi commented Aug 10, 2024

Pushing us in the direction of nerfstudio (splatfacto vs splatfacto-big, etc), this also makes it easier to have different sets of standard hyperparameters.

You can just add a new key/value pair to this dictionary:

    # Config objects we can choose between.
    # Each is a tuple of (CLI description, config object).
    configs = {
        "default": (
            "Gaussian splatting training using densification heuristics from the original paper.",
            Config(),
        ),
        "mcmc": (
            "Gaussian splatting training using densification  from the paper '3D Gaussian Splatting as Markov Chain Monte Carlo'.",
            Config(init_opa=0.5, init_scale=0.1, strategy=MCMCStrategy()),
        ),
    }

Copy link
Collaborator

@liruilong940607 liruilong940607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Brent!

@liruilong940607 liruilong940607 merged commit fc1a3ca into main Aug 10, 2024
2 checks passed
@liruilong940607 liruilong940607 deleted the brent/trainer_refactor branch August 10, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants