Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug related to refine_scale2d and add pause_refine_after_reset to default strategy #354

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

jb-ye
Copy link
Collaborator

@jb-ye jb-ye commented Aug 21, 2024

I am trying to find a configuration of simple_trainer mimic the behavior of splatfacto-big and happen to encounter some bugs. This is hotfix.

gsplat/strategy/default.py Outdated Show resolved Hide resolved
gsplat/strategy/default.py Show resolved Hide resolved
@jb-ye
Copy link
Collaborator Author

jb-ye commented Aug 21, 2024

@liruilong940607 I am working on converting splatfacto to use gsplat's strategy interface. I need a new option called pause_refine_after_reset in the interface.

@jb-ye jb-ye changed the title Fix bug related to refine_scale2d Fix bug related to refine_scale2d and add pause_refine_after_reset to default strategy Aug 21, 2024
Copy link
Collaborator

@liruilong940607 liruilong940607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@jb-ye jb-ye merged commit 44544f7 into nerfstudio-project:main Aug 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants