Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix points projection when sampling patches for training #386

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Fix points projection when sampling patches for training #386

merged 1 commit into from
Sep 4, 2024

Conversation

nnop
Copy link
Contributor

@nnop nnop commented Sep 4, 2024

fix #381

liruilong940607
liruilong940607 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@liruilong940607 liruilong940607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@liruilong940607 liruilong940607 merged commit f2b7acc into nerfstudio-project:main Sep 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liruilong940607 liruilong940607 liruilong940607 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A bug in points projection when enabling patch_size?
2 participants
@nnop @liruilong940607