Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow fix #423

Merged
merged 2 commits into from
Sep 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ on:
release:
types: [created]

permissions:
contents: write

jobs:

# Build the wheels using reusable_building.yml
Expand Down Expand Up @@ -68,6 +71,8 @@ jobs:
github_token: ${{ secrets.GITHUB_TOKEN }}
publish_dir: ./whl # Directory where the simple index pages are located
destination_dir: whl # The 'wh' folder in the GitHub Pages root
keep_files: false # This will only erase the destination subdirectory.
cname: docs.gsplat.studio

upload_pypi:
name: Upload to PyPi
Expand All @@ -80,6 +85,11 @@ jobs:
name: pypi_packages
path: dist

- name: Install dependencies
run: |
python -m pip install build twine
shell: bash

# - name: Publish package to Test PyPI
# uses: pypa/gh-action-pypi-publish@release/v1
# with:
Expand All @@ -90,4 +100,5 @@ jobs:
env:
PYPI_TOKEN: ${{ secrets.PYPI_TOKEN }}
run: |
twine upload --username __token__ --password $PYPI_TOKEN dist/*
twine upload --username __token__ --password $PYPI_TOKEN dist/*
shell: bash
4 changes: 2 additions & 2 deletions gsplat/rendering.py
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,8 @@ def rasterization(
distributed: Whether to use distributed rendering. Default is False. If True,
The input Gaussians are expected to be a subset of scene in each rank, and
the function will collaboratively render the images for all ranks.
ortho: Whether to use orthographic projection. In such case fx and fy become the scaling
factors to convert projected coordinates into pixel space and cx, cy become offsets.
camera_model: The camera model to use. Supported models are "pinhole", "ortho",
and "fisheye". Default is "pinhole".
covars: Optional covariance matrices of the Gaussians. If provided, the `quats` and
`scales` will be ignored. [N, 3, 3], Default is None.

Expand Down
Loading