Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

densify after optimizer step. fixes #426 #431

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

rahul-goel
Copy link
Contributor

Fixes #426.

I don't think it will have a change in the final quality metrics at all. Haven't tested though.

Copy link
Collaborator

@liruilong940607 liruilong940607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this LGTM!

@liruilong940607 liruilong940607 merged commit 22540f7 into nerfstudio-project:main Sep 30, 2024
2 checks passed
@rahul-goel rahul-goel deleted the packed_fix branch September 30, 2024 11:31
@rahul-goel rahul-goel restored the packed_fix branch September 30, 2024 11:31
@rahul-goel rahul-goel deleted the packed_fix branch September 30, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Sparse Tensors leading to incorrect gradients post densification.
2 participants