Add max_frames + max_output_size arguments for Aria data processing
#3466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentyi
changed the title
max_frames + max_image_size arguments for Aria data processingmax_frames + max_output_size arguments for Aria data processing
|
These changes make sense to me, but I am wondering about the fisheye_crop_radius If a user limits the resolution of the image to be smaller than 1408, the fisheye_crop_radius would have to decrease proportionally to their new resolution right? |
Yeah, the code is a little bit hard to follow but since I'm updating the camera calibration based on the new image resolution this does end up getting handled correctly! |
|
Ohh I see that now, yes this makes sense to me! I don't see any other glaring issues at the moment and this is definitely a nice flag to have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AntonioMacaronio this has been helpful for some of datasets recently. Does it make sense to you? ( I know there's also the other open Aria + data processing PRs )