Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SceneNodeHandle cleanup, bump version #113

Merged
merged 3 commits into from
Oct 11, 2023
Merged

SceneNodeHandle cleanup, bump version #113

merged 3 commits into from
Oct 11, 2023

Conversation

brentyi
Copy link
Collaborator

@brentyi brentyi commented Oct 10, 2023

No description provided.

kerrj
kerrj approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@kerrj kerrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, seems to work

@brentyi brentyi enabled auto-merge (squash) October 11, 2023 00:00
@brentyi brentyi merged commit a6c5542 into main Oct 11, 2023
12 checks passed
@brentyi brentyi deleted the brent/handle_cleanup branch October 11, 2023 00:03
yzslab pushed a commit to yzslab/viser that referenced this pull request Oct 20, 2024
@brentyi
SceneNodeHandle cleanup, bump version (nerfstudio-project#113)
1c14ca3 
* SceneNodeHandle cleanup

* Make `visible=` argument consistent

* Fix transform controls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerrj kerrj kerrj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brentyi @kerrj