Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add corner logo #117

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Add corner logo #117

merged 3 commits into from
Oct 20, 2023

Conversation

brentyi
Copy link
Collaborator

@brentyi brentyi commented Oct 20, 2023

image

Mild UX concern: does it look like a navigation tool?

@brentyi brentyi requested a review from tancik October 20, 2023 16:08
Copy link
Collaborator

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! LGTM. I wouldn't worry too much about the ux issue since it opens a new tab, so people will learn quickly.

@brentyi brentyi merged commit 64ced0c into main Oct 20, 2023
12 checks passed
@brentyi brentyi deleted the brent/logo branch October 20, 2023 16:54
yzslab pushed a commit to yzslab/viser that referenced this pull request Oct 20, 2024
* Add corner logo

* Update example markdown

* Remove unused imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants