Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI refinements, share URL QR code generation #193

Merged
merged 1 commit into from
Mar 23, 2024
Merged

UI refinements, share URL QR code generation #193

merged 1 commit into from
Mar 23, 2024

Conversation

brentyi
Copy link
Collaborator

@brentyi brentyi commented Mar 22, 2024

No description provided.

@brentyi brentyi requested a review from chungmin99 March 22, 2024 23:05
chungmin99
chungmin99 approved these changes Mar 23, 2024
View reviewed changes
Copy link
Collaborator

@chungmin99 chungmin99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! 👍 I've always disliked typing my share URLs manually into my phone.

@brentyi brentyi merged commit cbaddce into main Mar 23, 2024
12 checks passed
@brentyi brentyi deleted the brent/qr branch March 23, 2024 00:06
yzslab pushed a commit to yzslab/viser that referenced this pull request Oct 20, 2024
@brentyi
UI refinements, share URL QR code generation (nerfstudio-project#193)
752dcd7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chungmin99 chungmin99 chungmin99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brentyi @chungmin99