Ship client source with package #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentyi
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Thanks for the PR @atonderski! Installing via the Git URL is a standard pattern so we should support it. I can think about how to fix the bloat issue for PyPI releases.
yzslab
pushed a commit
to yzslab/viser
that referenced
this pull request
Oct 20, 2024
Co-authored-by: Brent Yi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that you cannot install viser using the
pip install git+urlpattern, since only the client build files are included.The follow fixes this, allowing
pip install git+url, but I guess at the expense of a more bloated package?Feel free to discard if this is not desired :)