Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix .add_image() race condition #206

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Fix .add_image() race condition #206

merged 2 commits into from
Apr 25, 2024

Conversation

brentyi
Copy link
Collaborator

@brentyi brentyi commented Apr 25, 2024

If textures weren't loaded quickly enough, addSceneNodeMakeParents could be called after SetPosition, SetOrientation messages were processed. This would incorrectly overwrite them.

@brentyi brentyi merged commit a62544c into main Apr 25, 2024
8 checks passed
@brentyi brentyi deleted the brent/fix_add_image_race_condition branch April 25, 2024 07:32
yzslab pushed a commit to yzslab/viser that referenced this pull request Oct 20, 2024
@brentyi
Fix race condition associated with .add_image() (nerfstudio-project…
58998f2 
…#206)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brentyi