Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty string case for plotly json loading (bugfix) #209

Merged
merged 3 commits into from
May 8, 2024

Conversation

chungmin99
Copy link
Collaborator

No description provided.

@chungmin99 chungmin99 marked this pull request as ready for review May 7, 2024 21:56
@chungmin99 chungmin99 requested a review from brentyi May 7, 2024 21:56
@chungmin99 chungmin99 changed the title Wrap plotly json loading around try/catch Handle empty string case for plotly json loading (bugfix) May 8, 2024
Copy link
Collaborator

@kerrj kerrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brentyi brentyi merged commit e1ef4b8 into main May 8, 2024
14 checks passed
@brentyi brentyi deleted the cmk/plotly-bugfix-json branch May 8, 2024 16:53
brentyi pushed a commit that referenced this pull request Jul 9, 2024
* Load json with try/catch, for malformed json

* Handle empty string input for plotly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants