Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MNDP by default #332

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add MNDP by default #332

wants to merge 1 commit into from

Conversation

lawik
Copy link

@lawik lawik commented Oct 21, 2024

This matches PRs to nerves to add MNDP for device discovery on local networks.

@lawik
Add MNDP by default
1ec563d 
This matches PRs to `nerves` to add MNDP for device discovery on local
networks.
@lawik lawik mentioned this pull request Oct 21, 2024
Open
@lawik
Copy link
Author

lawik commented Oct 21, 2024

I guess the safer variant might be to only run it on MIX_ENV=dev as I'm not sure people want it in production? I consider this a way to get the ball rolling and am happy to hold off or rework it.

I tested adding mndp this way and everything worked nicely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhunleth fhunleth Awaiting requested review from fhunleth

@mnishiguchi mnishiguchi Awaiting requested review from mnishiguchi

@jjcarstens jjcarstens Awaiting requested review from jjcarstens

@ConnorRigby ConnorRigby Awaiting requested review from ConnorRigby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lawik