Improve the verification of v value in signature #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@janx Could you review this change, especially the Ethereum part. |
XuJiandong
changed the title
XuJiandong
requested changes
Oct 24, 2023
XuJiandong
requested changes
Oct 24, 2023
c/auth.c
Outdated
|
|
||
| // where the V value will be 27 or 28 for legacy reasons | ||
| // https://ethereum.github.io/yellowpaper/paper.pdf | ||
| if (recid == 27 || recid == 28) { |
There was a problem hiding this comment.
37 and 38 are also possible.
There was a problem hiding this comment.
Yes, mainnet is this value. If we support mainnet, do we still need to support others? Or should we simply not support these?
There was a problem hiding this comment.
The chain relpay protection recovery id is calculated with this method: {0,1} + CHAIN_ID * 2 + 35 since EIP-155. It should be to consider. I don't think it is a good way to keep some available CHAIN_IDs. Because it's user's work.
XuJiandong
approved these changes
Oct 24, 2023
KaoImin
reviewed
Oct 24, 2023
c/auth.c
Outdated
Comment on lines
241
to
242
| // where the V value will be 27 or 28 for legacy reasons | ||
| // https://ethereum.github.io/yellowpaper/paper.pdf |
|
LGTM except the annotation |
KaoImin
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify the range of
vin sign more strictly based on official documentation or code.v = CHAIN_ID * 2 + 35orv = CHAIN_ID * 2 + 36.I see EIP-155 mentioned here
Test cases are being improved.