Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade ckb-std #44

Closed
wants to merge 1 commit into from
Closed

Conversation

quake
Copy link
Member

@quake quake commented Mar 20, 2024

supports native build

@quake quake requested a review from XuJiandong March 20, 2024 01:50
dynamic-library-memory-200 = ["enable-dynamic-library"]
# enable these features when memory is not enough
dynamic-library-memory-400 = ["enable-dynamic-library"]
dynamic-library-memory-600 = ["enable-dynamic-library"]

[dependencies]
ckb-std = "0.14.3"
ckb-std = { version = "0.15", default-features = false }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature allocator is missing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we didn't use default_alloc fn in this crate, no need to enable this feature of ckb-std.

@quake quake force-pushed the quake/native-build branch from 3521987 to a93b237 Compare March 25, 2024 09:57
@quake quake force-pushed the quake/native-build branch from a93b237 to 5778037 Compare March 25, 2024 10:29
@XuJiandong
Copy link
Collaborator

Already done in: #45

@XuJiandong XuJiandong closed this Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants